[Test] Add cpp linter workflow #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v12.0.0
Click here for the full clang-tidy patch
diff --git a/lib/JitEngine.cpp b/lib/JitEngine.cpp
index a1ea48f..1072ee9 100644
--- a/lib/JitEngine.cpp
+++ b/lib/JitEngine.cpp
@@ -82 +82 @@ void JitEngine::runOptimizationPassPipeline(Module &M, StringRef Arch,
- PipelineTuningOptions pto;
+ PipelineTuningOptions Pto;
Used clang-format v12.0.0
Click here for the full clang-format patch
diff --git a/pass/ProteusPass.cpp b/pass/ProteusPass.cpp
index bd78ad1..8804da6 100644
--- a/pass/ProteusPass.cpp
+++ b/pass/ProteusPass.cpp
@@ -1070 +1070,2 @@ private:
- if (F.getName().contains("jit_variable")) {JitFunctions.push_back(&F);
+ if (F.getName().contains("jit_variable")) {
+ JitFunctions.push_back(&F);
Have any feedback or feature suggestions? Share it here.
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v18.1.3
Click here for the full clang-tidy patch
diff --git a/lib/JitEngine.cpp b/lib/JitEngine.cpp
index a1ea48f..1072ee9 100644
--- a/lib/JitEngine.cpp
+++ b/lib/JitEngine.cpp
@@ -82 +82 @@ void JitEngine::runOptimizationPassPipeline(Module &M, StringRef Arch,
- PipelineTuningOptions pto;
+ PipelineTuningOptions Pto;
Used clang-format v18.1.3
Click here for the full clang-format patch
diff --git a/pass/ProteusPass.cpp b/pass/ProteusPass.cpp
index bd78ad1..8804da6 100644
--- a/pass/ProteusPass.cpp
+++ b/pass/ProteusPass.cpp
@@ -1070 +1070,2 @@ private:
- if (F.getName().contains("jit_variable")) {JitFunctions.push_back(&F);
+ if (F.getName().contains("jit_variable")) {
+ JitFunctions.push_back(&F);
Have any feedback or feature suggestions? Share it here.
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v18.1.3
Click here for the full clang-tidy patch
diff --git a/lib/JitEngine.cpp b/lib/JitEngine.cpp
index a1ea48f..1072ee9 100644
--- a/lib/JitEngine.cpp
+++ b/lib/JitEngine.cpp
@@ -82 +82 @@ void JitEngine::runOptimizationPassPipeline(Module &M, StringRef Arch,
- PipelineTuningOptions pto;
+ PipelineTuningOptions Pto;
Used clang-format v18.1.3
Click here for the full clang-format patch
diff --git a/pass/ProteusPass.cpp b/pass/ProteusPass.cpp
index bd78ad1..8804da6 100644
--- a/pass/ProteusPass.cpp
+++ b/pass/ProteusPass.cpp
@@ -1070 +1070,2 @@ private:
- if (F.getName().contains("jit_variable")) {JitFunctions.push_back(&F);
+ if (F.getName().contains("jit_variable")) {
+ JitFunctions.push_back(&F);
Have any feedback or feature suggestions? Share it here.
pass/ProteusPass.cpp
Outdated
| @@ -1067,8 +1067,7 @@ class ProteusJitPassImpl { | |||
| for (auto &F : M.getFunctionList()) { | |||
| // TODO: Demangle and search for the fully qualified proteus::jit_variable | |||
| // name. | |||
| if (F.getName().contains("jit_variable")) { | |||
| JitFunctions.push_back(&F); | |||
| if (F.getName().contains("jit_variable")) {JitFunctions.push_back(&F); | |||
There was a problem hiding this comment.
clang-format suggestion
Suggested change
| if (F.getName().contains("jit_variable")) {JitFunctions.push_back(&F); | |
| if (F.getName().contains("jit_variable")) { | |
| JitFunctions.push_back(&F); |
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v18.1.3
Click here for the full clang-tidy patch
diff --git a/lib/JitEngine.cpp b/lib/JitEngine.cpp
index 758d7fd..5cea6ea 100644
--- a/lib/JitEngine.cpp
+++ b/lib/JitEngine.cpp
@@ -139 +139 @@ void JitEngine::optimizeIR(Module &M, StringRef Arch) {
- for (int i = 0; i < 10; i++)
+ for (int I = 0; I < 10; I++)
Used clang-format v18.1.3
No concerns from clang-format.
Have any feedback or feature suggestions? Share it here.
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v18.1.3
Click here for the full clang-tidy patch
diff --git a/lib/JitEngine.cpp b/lib/JitEngine.cpp
index 758d7fd..5cea6ea 100644
--- a/lib/JitEngine.cpp
+++ b/lib/JitEngine.cpp
@@ -139 +139 @@ void JitEngine::optimizeIR(Module &M, StringRef Arch) {
- for (int i = 0; i < 10; i++)
+ for (int I = 0; I < 10; I++)
Used clang-format v18.1.3
No concerns from clang-format.
Have any feedback or feature suggestions? Share it here.
There was a problem hiding this comment.
Cpp-linter Review
Used clang-tidy v18.1.3
Click here for the full clang-tidy patch
diff --git a/lib/JitEngineDeviceCUDA.cpp b/lib/JitEngineDeviceCUDA.cpp
index d6c353e..b020478 100644
--- a/lib/JitEngineDeviceCUDA.cpp
+++ b/lib/JitEngineDeviceCUDA.cpp
@@ -315 +315 @@ JitEngineDeviceCUDA::JitEngineDeviceCUDA() {
- for (int i = 0; i < 10; ++i)
+ for (int I = 0; I < 10; ++I)
Used clang-format v18.1.3
No concerns from clang-format.
Have any feedback or feature suggestions? Share it here.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.